SteNicholas commented on code in PR #3504: URL: https://github.com/apache/celeborn/pull/3504#discussion_r2428043099
########## worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/PartitionMetaHandler.scala: ########## @@ -105,7 +107,7 @@ class MapPartitionMetaHandler( var currentSubpartition = 0 private var totalBytes = 0L private var regionStartingOffset = 0L - var indexChannel: FileChannel = createIndexFile + var indexFile: Either[FileChannel, FSDataOutputStream] = createIndexFile Review Comment: @FMX, which thread does `FSDataOutputStream` keep? BTW, `PartitionFilesSorter` also uses the same implementation, why does not `PartitionFilesSorter` have same problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
