SteNicholas commented on code in PR #3510: URL: https://github.com/apache/celeborn/pull/3510#discussion_r2443667689
########## assets/spark-patch/Celeborn_Columnar_Shuffle_spark3_5.patch: ########## @@ -0,0 +1,39 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +diff --git a/core/src/main/scala/org/apache/spark/Dependency.scala b/core/src/main/scala/org/apache/spark/Dependency.scala +index fbb92b4b4e2..a4580d94456 100644 +--- a/core/src/main/scala/org/apache/spark/Dependency.scala ++++ b/core/src/main/scala/org/apache/spark/Dependency.scala +@@ -82,6 +82,7 @@ class ShuffleDependency[K: ClassTag, V: ClassTag, C: ClassTag]( + val keyOrdering: Option[Ordering[K]] = None, + val aggregator: Option[Aggregator[K, V, C]] = None, + val mapSideCombine: Boolean = false, ++ var schema: AnyRef = null, + val shuffleWriterProcessor: ShuffleWriteProcessor = new ShuffleWriteProcessor) + extends Dependency[Product2[K, V]] with Logging { + +diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala +index 91f2099ce2d..2f71f8b8c57 100644 +--- a/sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala ++++ b/sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala +@@ -402,6 +402,7 @@ object ShuffleExchangeExec { Review Comment: Why not change line 405: https://github.com/apache/spark/blob/branch-3.5/sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala#L405? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
