SteNicholas commented on code in PR #3419:
URL: https://github.com/apache/celeborn/pull/3419#discussion_r2493753190
##########
common/src/main/scala/org/apache/celeborn/common/rpc/netty/Inbox.scala:
##########
@@ -285,6 +285,7 @@ private[celeborn] class Inbox(
// Note: The concurrent events in messages will be processed one by
one.
}
} finally {
+ metrics.close()
Review Comment:
fDoes `metric#dump` need to move into finally blocker? Because `addMessage`
may throw exception, which causes that metric would close before dumping.
##########
common/src/main/scala/org/apache/celeborn/common/rpc/netty/Inbox.scala:
##########
@@ -285,6 +285,7 @@ private[celeborn] class Inbox(
// Note: The concurrent events in messages will be processed one by
one.
}
} finally {
+ metrics.close()
Review Comment:
Does `metric#dump` need to move into finally blocker? Because `addMessage`
may throw exception, which causes that metric would close before dumping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
