turboFei commented on code in PR #3537: URL: https://github.com/apache/celeborn/pull/3537#discussion_r2520066158
########## docs/configuration/index.md: ########## @@ -204,6 +212,7 @@ during worker shutdown, workers should store the meta about reading shuffle part and restore the meta after restarting workers, also workers should keep a stable service port to support `ShuffleClient` retry reading data. Users should set `celeborn.worker.graceful.shutdown.enabled` to `true` and set below service port with stable port to support worker recover status. Review Comment: nit: is such blank line change necessary? ########## docs/configuration/index.md: ########## @@ -204,6 +212,7 @@ during worker shutdown, workers should store the meta about reading shuffle part and restore the meta after restarting workers, also workers should keep a stable service port to support `ShuffleClient` retry reading data. Users should set `celeborn.worker.graceful.shutdown.enabled` to `true` and set below service port with stable port to support worker recover status. + Review Comment: nit: is such blank line change necessary? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
