HolyLow commented on code in PR #3538:
URL: https://github.com/apache/celeborn/pull/3538#discussion_r2532586800
##########
cpp/celeborn/client/ShuffleClient.h:
##########
@@ -84,7 +96,43 @@ class ShuffleClientImpl : public ShuffleClient {
void shutdown() override {}
+ protected:
+ // The constructor is hidden to ensure that functionality of
+ // std::shared_from_this works properly.
+ ShuffleClientImpl(
+ const std::string& appUniqueId,
+ const std::shared_ptr<const conf::CelebornConf>& conf,
+ const std::shared_ptr<network::TransportClientFactory>& clientFactory);
+
+ // TODO: currently this function serves as a stub. will be updated in future
Review Comment:
I get what you mean, but the stub code here will be implemented in later
commits and is not unsupported feature. So I think it is ok to keep the stub
TODO here without the explicit JIRA ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
