RexXiong commented on code in PR #3479:
URL: https://github.com/apache/celeborn/pull/3479#discussion_r2536131559
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -4228,6 +4230,23 @@ object CelebornConf extends Logging {
.doubleConf
.createWithDefault(0.5)
+ val WORKER_PUSH_DATA_MERGE_BUFFER_ENABLED: ConfigEntry[Boolean] =
+ buildConf("celeborn.worker.pushdata.mergeBuffer.enabled")
+ .categories("worker")
+ .version("0.5.1")
+ .doc("enable merge low utilization push data's body buffer before write")
+ .booleanConf
+ .createWithDefault(true)
+
+ val WORKER_DIRECT_MEMORY_RATIO_TO_MERGE_BUFFER: ConfigEntry[Double] = {
+ buildConf("celeborn.worker.directMemoryRatioToMergeBuffer")
+ .categories("worker")
+ .version("0.5.1")
Review Comment:
ditto
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -4228,6 +4230,23 @@ object CelebornConf extends Logging {
.doubleConf
.createWithDefault(0.5)
+ val WORKER_PUSH_DATA_MERGE_BUFFER_ENABLED: ConfigEntry[Boolean] =
+ buildConf("celeborn.worker.pushdata.mergeBuffer.enabled")
+ .categories("worker")
+ .version("0.5.1")
Review Comment:
Minor: change the version to `0.6.2` and disable merge Buffer by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
