ChenYi015 commented on code in PR #3550:
URL: https://github.com/apache/celeborn/pull/3550#discussion_r2575709487
##########
charts/celeborn/templates/worker/statefulset.yaml:
##########
@@ -56,6 +56,9 @@ spec:
{{- end }}
{{- if $paths }}
initContainers:
+ {{- if .Values.worker.extraInitContainers }}
+ {{- tpl (toYaml .Values.worker.extraInitContainers) . | nindent 6 }}
+ {{- end }}
Review Comment:
1. Can be simplifed as:
```suggestion
{{- with .Values.worker.extraInitContainers }}
{{- toYaml . | nindent 6 }}
{{- end }}
```
2. The if statement `{{- if $paths }}` should be moved after
extraInitContainers, otherwise the `extraInitContainers` might not be rendered
due to empty paths list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
