afterincomparableyum commented on PR #3553: URL: https://github.com/apache/celeborn/pull/3553#issuecomment-3600138640
> @afterincomparableyum Thanks for your comments, indeed very helpful. Code is refactored as suggested. > > The TODOs will be collected in following PRs, and when it is ready I will ping you for further help. Currently the code is not stable yet, so it might be more proper to firstly converge on a runnable version and then solve the TODOs based on the runnable version with CI protections. > > Really appreciate your interest in this. Looking forward to make cppClient better with your contribution. > @afterincomparableyum Thanks for your comments, indeed very helpful. Code is refactored as suggested. > > The TODOs will be collected in following PRs, and when it is ready I will ping you for further help. Currently the code is not stable yet, so it might be more proper to firstly converge on a runnable version and then solve the TODOs based on the runnable version with CI protections. > > Really appreciate your interest in this. Looking forward to make cppClient better with your contribution. Sounds like a plan @HolyLow feel free to mention me in future PRs you make for cppClient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
