SteNicholas commented on code in PR #3554:
URL: https://github.com/apache/celeborn/pull/3554#discussion_r2583872072
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -6795,4 +6798,13 @@ object CelebornConf extends Logging {
.doc("Whether to mark shuffle data lost when unknown worker is
detected.")
.booleanConf
.createWithDefault(false)
+
+ val ENDPOINT_VERIFIER_SEPARATE_ENABLED: ConfigEntry[Boolean] =
+ buildConf("celeborn.rpc.RpcEndpointVerifier.separate.enabled")
+ .categories("network")
+ .version("0.7.0")
+ .doc("dispatcher will process RpcEndpointVerifier's request separately")
Review Comment:
```suggestion
.doc("Whether to enable dispatcher process RpcEndpointVerifier's
request separately.")
```
##########
common/src/main/scala/org/apache/celeborn/common/rpc/netty/Dispatcher.scala:
##########
@@ -255,6 +281,35 @@ private[celeborn] class Dispatcher(nettyEnv: NettyRpcEnv,
rpcSource: RpcSource)
}
}
+ /** Message loop used for dispatching messages. */
+ private class EndpointVerifierMessageLoop extends Runnable {
Review Comment:
Could you add some test case to verify?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
