Marcono1234 commented on code in PR #3555:
URL: https://github.com/apache/celeborn/pull/3555#discussion_r2611839896
##########
client/src/main/java/org/apache/celeborn/client/compress/Lz4Decompressor.java:
##########
@@ -68,7 +68,7 @@ public int decompress(byte[] src, byte[] dst, int dstOff)
throws IOException {
System.arraycopy(src, HEADER_LENGTH, dst, dstOff, originalLen);
break;
case COMPRESSION_METHOD_LZ4:
- int compressedLen2 = decompressor.decompress(src, HEADER_LENGTH, dst,
dstOff, originalLen);
+ int compressedLen2 = decompressor.decompress(src, HEADER_LENGTH,
originalLen, dst, dstOff);
Review Comment:
Just to clarify, I think using `LZ4SafeDecompressor` here would be fine. The
underlying decompression behavior should be identical. The difference is only
whether you have to specify expected compressed vs. the expected uncompressed
length, and what the return value represents.
As shown in the suggestion above.
But maybe it would make sense to do that in a separate PR indeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
