hcavarsan opened a new pull request, #3566:
URL: https://github.com/apache/celeborn/pull/3566
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX]
Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
Update `build/make-distribution.sh` to automatically fallback to system
`mvn` command when the bundled Maven wrapper (`build/mvn`) is not working
properly.
### Why are the changes needed?
The bundled Maven wrapper can fail silently or produce unusable output,
causing build failures like:
<img width="677" height="906" alt="CleanShot 2025-12-15 at 11 00 00"
src="https://github.com/user-attachments/assets/ab0497b6-6c29-4c99-9694-3701fbb3c767";
/>
When the bundled Maven doesn't work correctly, the script fails even if a
working system Maven is available. This change adds mvn detection and fallback:
- First tries the bundled Maven (preserving original behavior)
- If bundled Maven fails `--version` check, automatically falls back to
system `mvn`
- Provides clear warning message when fallback occurs
### Does this PR introduce _any_ user-facing change?
No. The default behavior remains unchanged - bundled Maven is still tried
first.
### How was this patch tested?
Tested build script with bundled Maven (broken in my local machine) with
auto detection and successful build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
