HolyLow commented on code in PR #3561:
URL: https://github.com/apache/celeborn/pull/3561#discussion_r2660336574
##########
client/src/main/scala/org/apache/celeborn/client/RequestLocationCallContext.scala:
##########
@@ -36,11 +37,12 @@ trait RequestLocationCallContext {
case class ChangeLocationsCallContext(
context: RpcCallContext,
- partitionCount: Int)
+ partitionCount: Int,
+ serdeVersion: SerdeVersion)
extends RequestLocationCallContext with Logging {
- val endedMapIds = new util.HashSet[Integer]()
+ val endedMapIds = new util.ArrayList[Integer]()
Review Comment:
ArrayList takes less overhead than HashSet, so here we change to use
ArrayList. Besides, it is more complex to convert between HashSet and
ProtoBuf's List data structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
