pltbkd opened a new pull request, #3589:
URL: https://github.com/apache/celeborn/pull/3589
…e for Flink clients
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX]
Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
1. Introduce a client-flink-common-tiered submodule to host the shared
tiered shuffle logic.
2. Introduce a shim layer to further unify the implementations and make
version-specific changes more explicit.
3. Unify the tests as well, so that versioned clients can simply run the
common test suite with their own shims.
### Why are the changes needed?
Though Celeborn now has a client-flink-common submodule, clients still have
to copy a lot of code from version to version, with small but necessary changes
buried in the duplicates. The tests don’t share a common implementation either.
Even worse, with Flink introducing tiered shuffle from 1.20 onward, all tiered
shuffle implementations must be placed inside the versioned clients to ensure
that client-flink-common can be compiled against all Flink versions. This makes
it much harder to evolve the tiered shuffle implementations.
For the maintenance of Flink clients in the future, we need better
organization of the submodules, consolidating the implementations and tests.
### Does this PR resolve a correctness bug?
No.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
The patch consolidates all current Flink client tests, and can be tested
with them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
