afterincomparableyum commented on code in PR #3575:
URL: https://github.com/apache/celeborn/pull/3575#discussion_r2750572779
##########
cpp/celeborn/client/ShuffleClient.cpp:
##########
@@ -57,7 +57,13 @@ ShuffleClientImpl::ShuffleClientImpl(
: appUniqueId_(appUniqueId),
conf_(conf),
clientFactory_(clientEndpoint.clientFactory()),
- pushDataRetryPool_(clientEndpoint.pushDataRetryPool()) {
+ pushDataRetryPool_(clientEndpoint.pushDataRetryPool()),
+ shuffleCompressionEnabled_(
+ conf->shuffleCompressionCodec() != protocol::CompressionCodec::NONE),
+ compressor_(
+ shuffleCompressionEnabled_
+ ? compress::Compressor::createCompressor(*conf)
+ : nullptr) {
Review Comment:
Constructor Initialization List Order:
appUniqueId_
conf_
clientFactory_
pushDataRetryPool_
shuffleCompressionEnabled_
compressorFactory_
The initialization order matches the declaration order.
The compression members (shuffleCompressionEnabled_ and compressorFactory_)
are declared after conf_ in the header in latest commit, and they're
initialized after conf_ in the constructor. This is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
