Dzeri96 opened a new pull request, #3599:
URL: https://github.com/apache/celeborn/pull/3599

   ### What changes were proposed in this pull request?
   The S3 Client in `S3MultipartUploadHandler` now uses the dynamic config 
`fs.s3a.aws.credentials.provider` in order to set its provider chain up.
   
   ### Why are the changes needed?
   Before this, it was only possible to use the hard-coded provider 
configuration.
   
   ### Does this PR resolve a correctness bug?
   Sort of.
   
   ### Does this PR introduce _any_ user-facing change?
   Yes, in the sense that `celebor.hadoop.fs.s3a.aws.credentials.provider` will 
now work correctly in the MultiPartHandler.
   
   ### How was this patch tested?
   Unit tests and a manual test.
   **Note**: I don't like having to change the class in order to make it 
testable, but I'm planning to get rid of this whole logic in another PR, where 
we will use the same hadoop-created S3 client everywhere.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to