Copilot commented on code in PR #3597:
URL: https://github.com/apache/celeborn/pull/3597#discussion_r2796501849
##########
common/src/main/scala/org/apache/celeborn/common/meta/WorkerInfo.scala:
##########
@@ -214,25 +214,21 @@ class WorkerInfo(
for (newDisk <- newDiskInfos.values().asScala) {
val mountPoint: String = newDisk.mountPoint
val curDisk = diskInfos.get(mountPoint)
+ if (estimatedPartitionSize.nonEmpty && !newDisk.storageType.isDFS) {
+ newDisk.maxSlots = newDisk.totalSpace / estimatedPartitionSize.get
+ newDisk.availableSlots = newDisk.actualUsableSpace /
estimatedPartitionSize.get
+ }
Review Comment:
This change introduces new slot-update semantics for DFS vs local disks
inside `updateThenGetDiskInfos`, but there are no unit tests covering that
remote/DFS disk slot fields are preserved across successive updates (e.g.,
registration `updateDiskSlots(...)` followed by heartbeat
`updateThenGetDiskInfos(...)`). Adding a focused test in `WorkerInfoSuite` for
a DFS `DiskInfo` would help prevent regressions like remote disks becoming
unavailable after the first heartbeat.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
