jaystarshot opened a new pull request, #3602:
URL: https://github.com/apache/celeborn/pull/3602
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX]
Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
- Switched Protobuf CMake integration from the legacy FindProtobuf module to
modern CONFIG mode with imported targets (protobuf::protoc,
protobuf::libprotobuf).
- Added install() rules for public headers, generated proto headers, and
static libraries so the C++ client can be consumed as an installed package.
- Added missing #include <set> in CelebornUtils.h.
### Why are the changes needed?
The legacy FindProtobuf module-variable style (${PROTOBUF_LIBRARY}, bare
protoc command) is fragile and does not work reliably with package managers
like vcpkg or Conan that provide Protobuf via CMake config files. Switching to
CONFIG mode and imported targets is the modern CMake best practice and ensures
the correct protoc binary and library are used regardless of the build
environment.
The install rules are needed so that downstream projects can consume the
Celeborn C++ client from a clean install prefix rather than pointing directly
at the source and build trees.
The missing <set> include was causing compilation failures in certain
toolchain configurations where the header was not transitively included.
### Does this PR resolve a correctness bug?
<!-- Yes/No. (Note: If yes, committer will add `correctness` label to
current pull request). -->
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
