eolivelli commented on code in PR #3604:
URL: https://github.com/apache/celeborn/pull/3604#discussion_r2827113737
##########
multipart-uploader/multipart-uploader-s3/src/main/java/org/apache/celeborn/S3MultipartUploadHandler.java:
##########
@@ -231,16 +248,12 @@ public void complete() {
@Override
public void abort() {
AbortMultipartUploadRequest abortMultipartUploadRequest =
- new AbortMultipartUploadRequest(bucketName, key, uploadId);
- s3Client.abortMultipartUpload(abortMultipartUploadRequest);
+ new AbortMultipartUploadRequest(sharedState.bucketName, key, uploadId);
+ sharedState.s3Client.abortMultipartUpload(abortMultipartUploadRequest);
}
@Override
- public void close() {
- if (s3Client != null) {
- s3Client.shutdown();
- }
- }
+ public void close() {}
Review Comment:
this is not needed, because the sharedState is handled by StorageManager
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
