afterincomparableyum commented on code in PR #3583:
URL: https://github.com/apache/celeborn/pull/3583#discussion_r2844458098
##########
cpp/celeborn/client/ShuffleClient.h:
##########
@@ -70,6 +72,10 @@ class ShuffleClient {
int endMapIndex,
bool needCompression) = 0;
+ virtual void excludeFailedFetchLocation(
+ const std::string& hostAndFetchPort,
+ const std::exception& e) = 0;
+
Review Comment:
it's likely best to match java client and use the
ShuffleClient::excludeFailedFetchLocation API. Will refactor code accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
