afterincomparableyum commented on code in PR #3605:
URL: https://github.com/apache/celeborn/pull/3605#discussion_r2866937552
##########
cpp/celeborn/client/reader/CelebornInputStream.cpp:
##########
@@ -169,11 +171,61 @@ bool CelebornInputStream::moveToNextChunk() {
std::unique_ptr<memory::ReadOnlyByteBuffer>
CelebornInputStream::getNextChunk() {
- // TODO: support the failure retrying, including excluding the failed
- // location, open a reader to read from the location's peer.
- auto chunk = currReader_->next();
- verifyChunk(chunk);
- return std::move(chunk);
+ while (fetchChunkRetryCnt_ < fetchChunkMaxRetry_) {
+ try {
+ if (isExcluded(currReader_->getLocation())) {
+ CELEBORN_FAIL(
+ "Fetch data from excluded worker! {}",
Review Comment:
I will work on adding some unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
