RexXiong commented on code in PR #3610:
URL: https://github.com/apache/celeborn/pull/3610#discussion_r2871098316
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StoragePolicy.scala:
##########
@@ -94,6 +94,7 @@ class StoragePolicy(conf: CelebornConf, storageManager:
StorageManager, source:
}
def tryCreateFileByType(storageInfoType: StorageInfo.Type): TierWriterBase
= {
+ val overrideType = if (evict) storageInfoType else
location.getStorageInfo.getType
Review Comment:
> @xy2953396112 is refactoring this code.
>
> I would prefer to keep this patch narrow and solve only the problem with
eviction.
>
> It seems to me that having more that 2 storage types (memoery, hdd, s3...)
still does not work well and it deserves a dedicated patch
Ok, make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
