RexXiong commented on PR #3662: URL: https://github.com/apache/celeborn/pull/3662#issuecomment-4244687151
Thanks for the fix. A suggestion: **Encapsulation of mapping cleanup**: I noticed that `celebornShuffleIdToAppShuffleIdMap.remove()` is only added in two places, but `unregisterShuffle` may be called from other locations as well. Those call sites would miss the mapping cleanup. Consider moving `celebornShuffleIdToAppShuffleIdMap.remove(shuffleId)` inside the `unregisterShuffle` method to ensure the mapping is always cleaned up when a shuffle is unregistered. This provides better encapsulation and avoids potential memory leaks or stale mappings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
