kaybhutani commented on code in PR #3659:
URL: https://github.com/apache/celeborn/pull/3659#discussion_r3179847455
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/ha/HARaftServer.java:
##########
@@ -628,13 +657,13 @@ void stepDown() {
REQUEST_TIMEOUT_MS);
RaftClientReply reply = server.transferLeadership(request);
if (reply.isSuccess()) {
- LOG.info("Successfully step down leader {}.", server.getId());
- } else {
- LOG.warn("Step down leader failed!");
+ return true;
}
+ LOG.warn("Step down leader {} failed.", server.getId());
} catch (Exception e) {
- LOG.warn("Step down leader failed!", e);
+ LOG.warn("Step down leader {} failed.", server.getId(), e);
}
+ return false;
Review Comment:
We already log `Successfully transferred leadership from {} in {}ms.` on
successful transfer, this one is redundant as per me but open to add it if
reviewers disagree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
