Copilot commented on code in PR #3673:
URL: https://github.com/apache/celeborn/pull/3673#discussion_r3214317727
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/DBProvider.java:
##########
@@ -23,11 +23,14 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import org.apache.celeborn.common.metrics.source.AbstractSource;
+
/** Note: code copied from Apache Spark. */
public class DBProvider {
private static final Logger logger =
LoggerFactory.getLogger(DBProvider.class);
Review Comment:
Changing the public static `DBProvider.initDB` signature (adding
`AbstractSource source`) is a breaking API/binary change for any external code
that might call this helper. Consider keeping the new overload but also
reintroducing the prior 3-arg `initDB(dbBackend, dbFile, version)` method that
delegates to the new one with `null` (or a default source) to preserve
compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
