pan3793 commented on code in PR #3685: URL: https://github.com/apache/celeborn/pull/3685#discussion_r3242188675
########## docs/developers/slotsallocation.md: ########## @@ -44,7 +45,7 @@ Load-aware slots allocation will take following elements into consideration. - disk's used slot Slots allocator will find out all worker involved in this allocation and sort their disks by -`disk's average flushtime * flush time weight + disk's average fetch time * fetch time weight`. +`disk's average flushtime * flush time weight + disk's average fetch time * fetch time weight + disk's active slots * active slots weight`. Review Comment: the flush/fetch time and slots number are different dimensions with different units, the value of them are different - flush/fetch time are in nano second, the value various from 10^6 ~ 10^9 (ms ~ s) typically, and slots are 10^5 (8T/64m), so it might need to configure a quite large "active slots weight" in practice. we should at least clearly document the unit of the value to avoid surprising users. another option is to normalize all values into the same range, then the weight becomes intuitive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
