afterincomparableyum opened a new pull request, #3693:
URL: https://github.com/apache/celeborn/pull/3693
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX]
Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
push-merged data, which exercises this fetch path more aggressively and
reliably triggered an EDEADLK abort.
The onSuccess_/onFailure_ callbacks are invoked on the TransportClient's IO
thread and capture a weak_ptr that is lifted to a shared_ptr inside the
callback body. When that local shared_ptr happens to hold the last reference,
dropping it inline runs WorkerPartitionReader on the IO executor's own thread,
which transitively destroys the embedded TransportClient and its
IOThreadPoolExecutor. The executor then attempts to pthread_join the thread
that is currently executing the callback and the join fails with EDEADLK,
aborting the process.
Hand the final reference off to the global CPU executor so destruction of
the reader (and the IO executor underneath it) always happens on a different
thread than the one running the callback.
### Why are the changes needed?
When running the bytedance bolt celeborn e2e tests for push-merged data I am
working on, I run into this error.
### Does this PR resolve a correctness bug?
Yes
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
I ran the Celeborn bolt e2e tests with this change and the tests passed with
push merged data support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
