Copilot commented on code in PR #3691:
URL: https://github.com/apache/celeborn/pull/3691#discussion_r3293902120
##########
common/src/main/java/org/apache/celeborn/common/client/MasterClient.java:
##########
@@ -171,14 +171,16 @@ private <T> T sendMessageInner(Object message, Class<T>
clz) throws Throwable {
private boolean shouldRetry(@Nullable RpcEndpointRef oldRef, Throwable e) {
// It will always throw celeborn exception , so we need to get the cause
// 'CelebornException: Exception thrown in awaitResult'
Review Comment:
The comment above `shouldRetry` says the client "will always throw celeborn
exception" and therefore must inspect `e.getCause()`, but with the new
bootstrap redirect behavior `setupEndpointRef` can now surface a
`RuntimeException` path as well. Consider updating this comment to reflect that
`findMasterNotLeaderException` walks the full cause chain (and why), rather
than implying the throwable is always a `CelebornException` wrapper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
