SteNicholas commented on code in PR #3670:
URL: https://github.com/apache/celeborn/pull/3670#discussion_r3298057375
##########
client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/HashBasedShuffleWriter.java:
##########
@@ -277,6 +277,8 @@ private byte[] getOrCreateBuffer(int partitionId) {
private void pushGiantRecord(int partitionId, byte[] buffer, int numBytes)
throws IOException {
logger.debug("Push giant record for partition {}, size {}.", partitionId,
numBytes);
+ shuffleClient.computeBatchCRC(
+ shuffleId, mapId, encodedAttemptId, partitionId, buffer, 0, numBytes);
int bytesWritten =
shuffleClient.pushData(
Review Comment:
Does `ShuffleClient#pushMergedData` need to compute batch crc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
