sunchao commented on code in PR #3692:
URL: https://github.com/apache/celeborn/pull/3692#discussion_r3299521280
##########
client-spark/spark-3/src/main/scala/org/apache/spark/shuffle/celeborn/CelebornShuffleReader.scala:
##########
@@ -272,8 +250,38 @@ class CelebornShuffleReader[K, C](
locations = filterLocations.asJava
}
partitionId2PartitionLocations.put(partitionId, locations)
- makeOpenStreamList(locations)
+ groupOpenStreamLocations(locations)
+ }
+ }
+
+ val clientsByHostPort = CelebornShuffleReader.createClientsInParallel(
Review Comment:
Addressed in d44fa479d. Added
`celeborn.client.spark.batch.openStream.parallelClientCreation.enabled`,
defaulting to `true`. Setting it to `false` uses the original serial
client-creation and request-building flow, providing a rollback switch for this
optimization. The configuration is documented and has a default/override test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
