pan3793 opened a new pull request, #3701:
URL: https://github.com/apache/celeborn/pull/3701
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX]
Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
As the title, it's a packaging change.
### Why are the changes needed?
I found that `celeborn-cli` always prints such warnings, but actually the
slf4j-api and log4j2 jars are correctly present in classpath.
```
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further
details.
...
```
after some investigation, I found that `celeborn-openapi-client-*.jar`
bundles shaded slf4j classes, which causes the issue.
```
$ jar tf $CELEBORN_HOME/cli-jars/celeborn-openapi-client-*.jar | grep slf4j
...
org/apache/celeborn/shaded/org/slf4j/
org/apache/celeborn/shaded/org/slf4j/ILoggerFactory.class
org/apache/celeborn/shaded/org/slf4j/IMarkerFactory.class
org/apache/celeborn/shaded/org/slf4j/Logger.class
...
```
### Does this PR resolve a correctness bug?
<!-- Check if yes. The `correctness` label will be added/removed
automatically. -->
- [ ] Yes
### Does this PR introduce _any_ user-facing change?
<!-- Check if yes. -->
- [ ] Yes
### How was this patch tested?
Tested with `celeborn-cli`, `SLF4J` binding warnings have gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
