sunchao opened a new pull request, #3714: URL: https://github.com/apache/celeborn/pull/3714
### What changes were proposed in this pull request? Export a new master `RequestSlotsFailed` counter with a bounded `status` label for `SLOT_NOT_AVAILABLE` and `WORKER_EXCLUDED`. This patch also makes metric-specific labels override configured `celeborn.metrics.extraLabels`, while preserving reserved `role` and `instance` labels. Configured extra labels are snapshotted when a metrics source is constructed so labeled metric keys remain stable. ### Why are the changes needed? `RequestSlots` placement failures directly affect shuffle registration, but existing master metrics do not expose whether applications are receiving these failure responses. The new counter provides a direct monitoring signal. Without the label precedence change, an extra label such as `status=prod` shadows the metric-specific failure reason and collapses both series. ### Does this PR resolve a correctness bug? - [ ] Yes ### Does this PR introduce _any_ user-facing change? - [x] Yes ### How was this patch tested? - `JAVA_HOME=$(brew --prefix openjdk@17) dev/reformat` - `JAVA_HOME=$(brew --prefix openjdk@17) build/mvn --no-transfer-progress -DskipTests -DprotocPluginExecutable=/tmp/protoc-gen-grpc-java-noop-proto3-optional -pl master -am install` - `JAVA_HOME=$(brew --prefix openjdk@17) build/mvn --no-transfer-progress -DprotocPluginExecutable=/tmp/protoc-gen-grpc-java-noop-proto3-optional -Dsuites=org.apache.celeborn.common.metrics.source.CelebornSourceSuite -pl common test-compile scalatest:test` - `JAVA_HOME=$(brew --prefix openjdk@17) build/mvn --no-transfer-progress -DprotocPluginExecutable=/tmp/protoc-gen-grpc-java-noop-proto3-optional -Dsuites=org.apache.celeborn.service.deploy.master.MasterSourceSuite,org.apache.celeborn.service.deploy.master.MasterSuite -pl master test-compile scalatest:test` The local `protocPluginExecutable` override is an ARM workstation workaround for the downloaded `protoc-gen-grpc-java` artifact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
