s0nskar opened a new pull request, #3719:
URL: https://github.com/apache/celeborn/pull/3719
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX]
Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
This PR lets a worker advertise tags at startup and makes tags part of
WorkerInfo, so they will use existing Raft replication and worker-lifecycle
cleanup. This also gel well with current implementation, allowing tags from
config service to be merged with worker supplied tags.
Backward Compatible:
- The behaviour remains unchanged when no worker supplied tags are
configured.
- A master-side config `celeborn.tags.worker.registration.enabled` (default:
true), will allow to ignore worker-supplied tags.
- If worker is running on older version, worker supplied tags will be empty.
### Why are the changes needed?
`TagsManager` today only works off the dynamic-config store. There is no way
for a worker to declare its own tags. This makes this feature a little hard to
use.
After this PR a worker can supply its own tags and manage its own tags
lifecycle and still allow tags overriding via config service. This will make
worker tags feature a lot easier to use.
### Does this PR resolve a correctness bug?
<!-- Check if yes. The `correctness` label will be added/removed
automatically. -->
- [ ] Yes
### Does this PR introduce _any_ user-facing change?
<!-- Check if yes. -->
- [X] Yes
### How was this patch tested?
- Added Unit Tests.
- Working on end-to-end testing in local setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
