SteNicholas commented on code in PR #3723:
URL: https://github.com/apache/celeborn/pull/3723#discussion_r3396326060
##########
charts/celeborn/tests/configmap_test.yaml:
##########
@@ -47,4 +47,13 @@ tests:
asserts:
- matchRegex:
path: data["celeborn-defaults.conf"]
- pattern: "(?m)^\\s*celeborn\\.master\\.internal\\.endpoints\\s*=.*"
+ pattern: "(?m)^\\s*celeborn\\.master\\.internal\\.endpoints=.*"
+
+ - it: Should render master endpoints keys with consistent key=value spacing
+ asserts:
+ - matchRegex:
+ path: data["celeborn-defaults.conf"]
+ pattern: "(?m)^\\s*celeborn\\.master\\.endpoints=.*"
+ - matchRegex:
+ path: data["celeborn-defaults.conf"]
+ pattern: "(?m)^\\s*celeborn\\.master\\.internal\\.endpoints=.*"
Review Comment:
Minor: this `celeborn.master.internal.endpoints=` assert duplicates the
(tightened) assert in the preceding test, so the internal.endpoints coverage
now lives in two places. The genuinely new bit is the
`celeborn.master.endpoints=` assert above.
Optional: since the PR's goal is enforcing no-space `=`, a negative guard
like `notMatchRegex` on a spaced-separator pattern would actually protect *all*
keys from regressing, whereas the positive `matchRegex` only checks these two
specific keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
