SteNicholas commented on code in PR #3724:
URL: https://github.com/apache/celeborn/pull/3724#discussion_r3400463645
##########
cpp/celeborn/client/ShuffleClient.cpp:
##########
@@ -858,6 +904,12 @@ bool ShuffleClientImpl::cleanupShuffle(int shuffleId) {
return true;
}
+void ShuffleClientImpl::shutdown() {
Review Comment:
Done in 294f89377 — `shutdown()` now also clears `fetchExcludedWorkers_`, so
both client-wide exclusion sets are reset like Java. The pools/managers (revive
manager, retry pool, client factory) are torn down by the destructor (RAII), so
shutdown() intentionally only clears the two exclusion sets; added a comment to
note that.
##########
cpp/celeborn/client/ShuffleClient.cpp:
##########
@@ -858,6 +904,12 @@ bool ShuffleClientImpl::cleanupShuffle(int shuffleId) {
return true;
}
+void ShuffleClientImpl::shutdown() {
Review Comment:
Branch rebased onto `main`; this change now lives in `294f89377` (rebased
equivalent of `f22033679`, identical diff).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
