afterincomparableyum opened a new pull request, #3735:
URL: https://github.com/apache/celeborn/pull/3735
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX]
Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
CELEBORN-1601 added ReviseLostShuffles support but only wired up the encode
side (toTransportMessage), the master handler, and the client sender. The
corresponding decode cases in ControlMessages.fromTransportMessage were never
added. Since that match has no default case, receiving a REVISE_LOST_SHUFFLES
(89) request on the master or a REVISE_LOST_SHUFFLES_RESPONSE (90) on the
client throws a MatchError, so the feature is broken over RPC. The existing
test exercises handleReviseLostShuffles directly and bypasses the RPC
round-trip, which is why this was probably not caught.
To fix, I added the missing REVISE_LOST_SHUFFLES_VALUE and
REVISE_LOST_SHUFFLES_RESPONSE_VALUE cases so the messages deserialize into
PbReviseLostShuffles / PbReviseLostShufflesResponse.
I also added a round trip test in UtilsSuite covering both messages.
### Why are the changes needed?
To fix an existing bug.
### Does this PR resolve a correctness bug?
<!-- Check if yes. The `correctness` label will be added/removed
automatically. -->
- [1] Yes
### Does this PR introduce _any_ user-facing change?
<!-- Check if yes. -->
- [ ] Yes
### How was this patch tested?
CI/CD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
