SteNicholas commented on code in PR #3695:
URL: https://github.com/apache/celeborn/pull/3695#discussion_r3417851645
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -4533,6 +4528,54 @@ object CelebornConf extends Logging {
.checkValues(Set("LEVELDB", "ROCKSDB"))
.createWithDefault("ROCKSDB")
+ val WORKER_RECOVER_DB_AUTO_RECOVERY: ConfigEntry[Boolean] =
+
buildConf("celeborn.worker.graceful.shutdown.recoverDb.rocksdb.autoRecovery.enabled")
+ .categories("worker")
+ .doc("If true, the metadata DB will automatically attempt to recover
from RocksDBException " +
+ "errors during put/get/delete operations. Recovery tries a safe
reopen. " +
+ "If false, RocksDBException errors are propagated directly to the
caller.")
+ .version("0.7.0")
+ .booleanConf
+ .createWithDefault(false)
+
+ private val rocksDBCompressionTypes: Set[String] =
+ RocksDBCompressionType.values().map(_.name()).toSet
+
+ val WORKER_RECOVER_DB_ROCKSDB_COMPRESSION: ConfigEntry[String] =
+
buildConf("celeborn.worker.graceful.shutdown.recoverDb.rocksdb.compression")
+ .categories("worker")
+ .doc("Compression type for the recover DB RocksDB upper levels. " +
+ "Must be a valid org.rocksdb.CompressionType value, e.g.
LZ4_COMPRESSION, " +
+ "ZSTD_COMPRESSION, SNAPPY_COMPRESSION, NO_COMPRESSION.")
+ .version("0.7.0")
+ .stringConf
+ .transform(_.toUpperCase(Locale.ROOT))
+ .checkValues(rocksDBCompressionTypes)
+ .createWithDefault(RocksDBCompressionType.LZ4_COMPRESSION.name())
+
+ val WORKER_RECOVER_DB_ROCKSDB_BOTTOMMOST_COMPRESSION: ConfigEntry[String] =
+
buildConf("celeborn.worker.graceful.shutdown.recoverDb.rocksdb.bottommostCompression")
+ .categories("worker")
+ .doc("Compression type for the recover DB RocksDB bottommost level. " +
+ "Higher-ratio codecs (e.g. ZSTD_COMPRESSION) trade CPU for disk space
and " +
+ "are typically a good fit since the bottommost level holds the most
data. " +
+ "Must be a valid org.rocksdb.CompressionType value.")
+ .version("0.7.0")
+ .stringConf
+ .transform(_.toUpperCase(Locale.ROOT))
+ .checkValues(rocksDBCompressionTypes)
+ .createWithDefault(RocksDBCompressionType.ZSTD_COMPRESSION.name())
+
+ val WORKER_RECOVER_DB_ROCKSDB_BLOOM_FILTER_BITS_PER_KEY: ConfigEntry[Double]
=
Review Comment:
```suggestion
val WORKER_RECOVERDB_ROCKSDB_BLOOMFILTER_BITSPERKEY: ConfigEntry[Double] =
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
