s0nskar commented on code in PR #3726:
URL: https://github.com/apache/celeborn/pull/3726#discussion_r3482085108
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -6998,9 +6998,13 @@ object CelebornConf extends Logging {
buildConf("celeborn.client.shuffleDataLostOnUnknownWorker.enabled")
.categories("client")
.version("0.6.3")
- .doc("Whether to mark shuffle data lost when unknown worker is
detected.")
+ .doc("When enabled, any shuffle that had partitions on the (crashed) " +
+ "unknown worker is immediately marked as data lost. " +
+ "On the write flow revive/commit request for that shuffle will fast
fail. " +
+ "GetReducerFileGroup requests are replied with SHUFFLE_DATA_LOST. " +
+ "This has no effect when ${CLIENT_PUSH_REPLICATE_ENABLED.key}=true")
.booleanConf
- .createWithDefault(false)
+ .createWithDefault(true)
Review Comment:
I will keep the default as false, as it make sense that making it true will
fast fail and not everyone would want that. People can optionally opt in for
this.
> even if its partitions were already revived/migrated to healthy workers.
This is not correct BTW.
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -6998,9 +6998,13 @@ object CelebornConf extends Logging {
buildConf("celeborn.client.shuffleDataLostOnUnknownWorker.enabled")
.categories("client")
.version("0.6.3")
- .doc("Whether to mark shuffle data lost when unknown worker is
detected.")
+ .doc("When enabled, any shuffle that had partitions on the (crashed) " +
+ "unknown worker is immediately marked as data lost. " +
+ "On the write flow revive/commit request for that shuffle will fast
fail. " +
+ "GetReducerFileGroup requests are replied with SHUFFLE_DATA_LOST. " +
+ "This has no effect when ${CLIENT_PUSH_REPLICATE_ENABLED.key}=true")
.booleanConf
- .createWithDefault(false)
+ .createWithDefault(true)
Review Comment:
I will keep the default as false, as it make sense that making it true will
fast fail and not everyone would want that. People can optionally opt in for
this.
> even if its partitions were already revived/migrated to healthy workers.
This is not correct BTW.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
