afterincomparableyum commented on code in PR #3737:
URL: https://github.com/apache/celeborn/pull/3737#discussion_r3489426384
##########
master/src/test/java/org/apache/celeborn/service/deploy/master/clustermeta/ha/RatisMasterStatusSystemSuiteJ.java:
##########
@@ -119,6 +119,15 @@ public static void resetRaftServer(
while (!serversStarted) {
try {
+ // Re-point each server to a fresh storage directory on every attempt.
Ratis releases the
+ // storage directory lock asynchronously on close(), so a failed
attempt (e.g. a random
+ // ratis port collision) can leave the previous directory locked.
Reusing the same
+ // directory on retry then fails with "directory is already locked";
allocating a clean
+ // directory each time avoids contending for a lock that has not been
released yet.
+ configureServerConf(conf1, 1);
Review Comment:
I can add a retry counter. If I notice it flaking though due to this, I will
revert it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
