sunchao commented on PR #3746: URL: https://github.com/apache/celeborn/pull/3746#issuecomment-4910537370
Follow-up on the two review-summary-only notes: - The cause-chain lookup now uses `Throwables.getCausalChain()`. - I intentionally left worker-side `ExecutionException` behavior unchanged. Cancellation of the waiting caller makes `Future.get()` throw `InterruptedException`; that path restores the caller-thread interrupt flag and cancels remaining workers in `finally`. If only a worker is interrupted, the caller receives `ExecutionException`; setting the caller-thread interrupt flag in that case would transfer a thread-local signal across threads. The worker helper restores its own flag before rethrowing. The full follow-up is in `311bc8c1c`, and the PR description now reflects the final one-attempt design and focused validation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
