Kalvin2077 opened a new pull request, #3755: URL: https://github.com/apache/celeborn/pull/3755
### What changes were proposed in this pull request? This PR adds Heartbeat message decoding support to the C++ client network. ### Why are the changes needed? The HEARTBEAT type (id 22) is already declared in the Message::Type enum and recognized by decodeType, but Message::decodeFrom had no case for it, so any heartbeat frame received by the C++ client hit the unsupported Message decode type failure path. As the protocol/server side begins to send heartbeat messages, the C++ client must be able to decode them instead of throwing. ### Does this PR resolve a correctness bug? - [ ] Yes ### Does this PR introduce any user-facing change? - [ ] Yes ### How was this patch tested? Added MessageTest.decodeHeartbeat, which constructs a heartbeat wire frame and asserts that Message::decodeFrom returns a non-null message with type HEARTBEAT. Built and ran the test with -- gtest_filter="MessageTest.decodeHeartbeat" inside the jraaaay/celeborn-cpp-dev:0.4 container; it passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
