Copilot commented on code in PR #3737:
URL: https://github.com/apache/celeborn/pull/3737#discussion_r3575662201
##########
common/src/main/scala/org/apache/celeborn/common/util/Utils.scala:
##########
@@ -258,6 +258,10 @@ object Utils extends Logging {
ScalaRandom.nextInt(until - 1 - from) + from
}
Review Comment:
selectRandomInt(from, until) is documented to return a value in [from,
until), but the current implementation uses `nextInt(until - 1 - from)`, which
(a) never returns `until - 1` and (b) throws when `until == from + 1` even
though that is a valid single-element range. Since this PR introduces
Utils.selectRandomPort() built on selectRandomInt, it will inherit the
off-by-one behavior.
##########
common/src/test/scala/org/apache/celeborn/RandomPortSupport.scala:
##########
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.celeborn
+
+import java.io.IOException
+import java.net.{InetSocketAddress, Socket}
+
+import org.apache.celeborn.common.util.Utils
+
+/**
+ * Shared random-port picker for cluster-setup test traits. Draws ports below
the ephemeral floor
+ * (via [[Utils.selectRandomPort]]) and remembers the ports it has handed out
so repeated calls
+ * within a suite do not collide, retrying if a candidate is already used or
currently bound.
+ */
+trait RandomPortSupport {
+ val usedPorts = new java.util.HashSet[Integer]()
+
+ def portBounded(port: Int): Boolean = {
+ val socket = new Socket()
+ try {
+ socket.connect(new InetSocketAddress("localhost", port), 100)
+ true
+ } catch {
+ case _: IOException => false
+ } finally {
+ socket.close()
+ }
+ }
+
+ def selectRandomPort(): Int = synchronized {
+ val port = Utils.selectRandomPort()
+ val portUsed = usedPorts.contains(port) || portBounded(port)
Review Comment:
The helper name `portBounded` reads like a typo ("bounded") rather than
"bound". Since this trait is new and the method is only used internally,
consider renaming it to avoid propagating the typo into more call sites.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
