senthh opened a new pull request, #3758:
URL: https://github.com/apache/celeborn/pull/3758
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX]
Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
This PR adds a new `JmxSink` metrics sink that exposes Celeborn metrics as
JMX MBeans.
- Add `JmxSink`
(`common/src/main/scala/org/apache/celeborn/common/metrics/sink/JmxSink.scala`),
backed by Dropwizard Metrics' `JmxReporter`. It follows the existing `Sink`
contract and is loaded reflectively by `MetricsSystem` via the standard
`(Properties, MetricRegistry)` constructor, so no changes to `MetricsSystem`
are required.
- Add the `io.dropwizard.metrics:metrics-jmx` dependency (which contains
`JmxReporter` in Dropwizard Metrics 4.x) to both the Maven build (`pom.xml`
dependency management + `common/pom.xml`) and the SBT build
(`project/CelebornBuild.scala`), pinned to the existing
`${codahale.metrics.version}` (4.2.25).
- Add a commented-out example to `conf/metrics.properties.template` and
`charts/celeborn/files/conf/metrics.properties` showing how to enable the sink.
- Document `JmxSink` in `docs/monitoring.md`.
- Register `metrics-jmx-4.2.25.jar` in all `dev/deps/dependencies-*`
manifests (server + client profiles) and add
`io.dropwizard.metrics:metrics-jmx` to `LICENSE-binary`, since the artifact is
now bundled in the distributions.
Enabling the sink is opt-in:
```properties
*.sink.jmx.class=org.apache.celeborn.common.metrics.sink.JmxSink
Test Output:
<img width="2630" height="1600" alt="image"
src="https://github.com/user-attachments/assets/673aff72-dce0-4038-b11f-a66a6a88a4b4";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
