Copilot commented on code in PR #3767:
URL: https://github.com/apache/celeborn/pull/3767#discussion_r3636341424
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/ha/HARaftServer.java:
##########
@@ -446,11 +446,18 @@ private Parameters configureSsl(CelebornConf conf,
RaftProperties properties, Rp
return null;
}
+ // Build the Ratis SSLFactory from the dedicated `ratis` SSL module when
it is explicitly
+ // enabled, otherwise fall back to the client-facing `rpc_service` module.
This decouples the
+ // inter-master Ratis cert from the client-facing rpc_service cert while
keeping existing
+ // (rpc_service-only) deployments byte-for-byte unchanged. This mirrors
+ // MasterClusterInfo.ratisSslModule (kept in sync as the single source of
truth for the policy).
+ String sslModule =
+ conf.sslEnabled(TransportModuleConstants.RATIS_MODULE)
+ ? TransportModuleConstants.RATIS_MODULE
+ : TransportModuleConstants.RPC_SERVICE_MODULE;
Review Comment:
This comment says MasterClusterInfo.ratisSslModule is the “single source of
truth”, but the policy is currently duplicated here (ternary) and in
MasterClusterInfo, which risks drift. Prefer calling the helper directly to
actually centralize the logic (and avoid leaving ratisSslModule unused).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
