yew1eb opened a new pull request, #3783:
URL: https://github.com/apache/celeborn/pull/3783

   ### What changes were proposed in this pull request?
   
   Fix a typo in `master_rest_v1.yaml`: the `SendWorkerEventRequest` schema 
declared `worker` in its `required` list, but the actual property name is 
`workers`.
   
   ### Why are the changes needed?
   
   The openapi-generator silently ignores the non-existent `worker` field, so 
the generated client compiles fine, but the spec declares a required field that 
does not exist and Swagger UI misleadingly shows `worker` as required. The 
server side validates `request.getWorkers.isEmpty`, consistent with the 
`workers` property.
   
   ### Does this PR resolve a correctness bug?
   
   - [ ] Yes
   
   ### Does this PR introduce _any_ user-facing change?
   
   - [x] Yes
   
   The OpenAPI spec and Swagger UI now correctly mark `workers` (instead of the 
non-existent `worker`) as a required field of `SendWorkerEventRequest`.
   
   ### How was this patch tested?
   
   - Regenerated the openapi client (`./build/mvn clean generate-sources -pl 
openapi/openapi-client`): no diff in generated code, as the generator does not 
emit anything for `required`.
   - The module builds successfully, which also validates the YAML syntax.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to