Copilot commented on code in PR #3745:
URL: https://github.com/apache/celeborn/pull/3745#discussion_r3726276170
##########
client/src/main/scala/org/apache/celeborn/client/commit/ReducePartitionCommitHandler.scala:
##########
@@ -545,19 +619,41 @@ class ReducePartitionCommitHandler(
override def handleGetReducerFileGroup(
context: RpcCallContext,
shuffleId: Int,
+ startPartition: Int,
+ endPartition: Int,
+ hasPartitionRange: Boolean,
+ omitMapAttempts: Boolean,
serdeVersion: SerdeVersion): Unit = {
// Quick return for ended stage, avoid occupy sync lock.
if (isStageEnd(shuffleId)) {
- replyGetReducerFileGroup(context, shuffleId, serdeVersion)
+ replyGetReducerFileGroup(
+ context,
+ shuffleId,
+ startPartition,
+ endPartition,
+ hasPartitionRange,
+ omitMapAttempts,
+ serdeVersion)
} else {
getReducerFileGroupRequest.synchronized {
// If setStageEnd() called after isStageEnd and before got lock,
should reply here.
if (isStageEnd(shuffleId)) {
- replyGetReducerFileGroup(context, shuffleId, serdeVersion)
+ replyGetReducerFileGroup(
+ context,
+ shuffleId,
+ startPartition,
+ endPartition,
+ hasPartitionRange,
+ omitMapAttempts,
+ serdeVersion)
} else {
getReducerFileGroupRequest.get(shuffleId).add(new
MultiSerdeVersionRpcContext(
context,
- serdeVersion))
+ serdeVersion,
+ startPartition,
+ endPartition,
+ hasPartitionRange,
+ omitMapAttempts))
Review Comment:
`getReducerFileGroupRequest.get(shuffleId)` can be null here (it’s only
populated in `registerShuffle`). If a reducer file-group request arrives before
`registerShuffle` (which can happen when `registeredShuffle` doesn’t contain
the shuffle yet, e.g., the early-downstream scenario described in
`LifecycleManager.handleGetReducerFileGroup`), this will throw an NPE and fail
the RPC instead of returning a meaningful status.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
