zaynt4606 commented on PR #3790: URL: https://github.com/apache/celeborn/pull/3790#issuecomment-5238215121
Thanks for the fix. One suggestion on the tests: both new interop tests use `AES/CBC/PKCS5Padding`. It would be good to add one more case that uses the default cipher transformation (no explicit `IO_CRYPTO_CIPHER_TRANSFORMATION` set) to cover the default path and guard against future regressions there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
