yew1eb commented on code in PR #3812:
URL: https://github.com/apache/celeborn/pull/3812#discussion_r3819723464


##########
.github/workflows/sbt.yml:
##########
@@ -53,6 +53,16 @@ jobs:
         distribution: zulu
         java-version: ${{ matrix.java }}
         check-latest: false
+    - name: Cache SBT launcher and dependencies
+      uses: actions/cache@v4
+      with:
+        path: |
+          build/*.jar
+          ~/.sbt
+          ~/.cache/coursier
+        key: sbt-${{ hashFiles('**/pom.xml', 'project/build.properties', 
'build/sbt', 'build/sbt-launch-lib.bash') }}
+        restore-keys: |
+          sbt-

Review Comment:
   Addressed: the cache key is now scoped by job and matrix dimensions 
(`sbt-${{ github.job }}-${{ matrix.java }}-${{ matrix.scala }}-${{ matrix.spark 
}}${{ matrix.flink }}-...`), and `hashFiles` covers the SBT build definition 
files (`project/**/*.scala`, `project/**/*.sbt`) instead of `pom.xml`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to