shellfish007 commented on PR #3766: URL: https://github.com/apache/celeborn/pull/3766#issuecomment-5427038936
@SteNicholas thanks — OSS resource consumption is now included in this PR. It had the identical gap to S3: `DiskFileInfo.isDFS()` is true for OSS, so OSS files were excluded from the local-disk bucket, while `isHdfs()` is false, so they were excluded from the HDFS bucket too. The OSS support mirrors the S3 accounting end to end: - `PbResourceConsumption` / `ResourceConsumption`: `ossBytesWritten` / `ossFileCount` (additive proto fields 8 and 9, defaulted to 0), included in `add` / `subtract` / `toString` / `simpleString` - `StorageManager.resourceConsumption()`: tallies `fileInfos.filter(_.isOSS)` - `Worker`: emits `ossFileCount` / `ossBytesWritten` gauges when `hasOssStorage` (and removes them on app cleanup); OSS bytes are included in the top-N app ranking - `ResourceConsumptionSource`, `PbSerDeUtils`, `MetaUtil`: metric names and round-trip The branch has also been updated with the latest `main`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
