Kalvin2077 commented on code in PR #3829:
URL: https://github.com/apache/celeborn/pull/3829#discussion_r3893188798
##########
client/src/main/java/org/apache/celeborn/client/read/DfsPartitionReader.java:
##########
@@ -283,10 +284,16 @@ public ByteBuf next() throws Exception {
results.put(Pair.of(currentChunkIndex,
Unpooled.wrappedBuffer(buffer)));
logger.debug("add index {} to results", currentChunkIndex++);
}
- } catch (Exception e) {
- logger.warn("Fetch thread is cancelled.", e);
- exception.set(e);
+ } catch (InterruptedException e) {
// cancel a task for speculative, ignore this exception
+ logger.warn("Read thread is interrupted.", e);
+ } catch (Throwable t) {
Review Comment:
Fixed. Set flag for CELEBORN-2154. Remove wrong comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
