wang-haihua commented on code in PR #3837:
URL: https://github.com/apache/celeborn/pull/3837#discussion_r3924649788
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionDataWriter.java:
##########
@@ -265,6 +265,11 @@ public PartitionSplitMode getSplitMode() {
@Override
public void notifyError(String mountPoint, DiskStatus diskStatus) {
+ // A committed file is already flushed and visible to fetch requests,
+ // a device error broadcast must not destroy it.
+ if (currentTierWriter.committed()) {
+ return;
+ }
Review Comment:
Fixed in a3b17223a by making notifyError synchronized. I think no deadlock
risk: the only lock order is ObservedDevice → PartitionDataWriter; the destroy
→ unregisterFileWriter path removes from a ConcurrentHashMap.newKeySet and
never takes the ObservedDevice lock. @SteNicholas PTAL, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
